[KYUUBI #6291] Avoid NPE in MySQLErrPacket #6292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribution built without enabling web ui # 🔍 Description Improve message of distribution built without enabling web ui. ## Issue References 🔗 This pull request fixes apache#6283 ## Describe Your Solution 🔧 Here is my implement: <img width="1512" alt="image" src="https://github.com/apache/kyuubi/assets/34719039/fc5e859e-1c92-44a1-8e27-316986c5d9c3"> ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6288 from dupen01/issue-6283. Closes apache#6288 a5886e2 [dupeng] revise the message of page bad14a7 [dupeng] improve the message of distribution built without enabling web ui Authored-by: dupeng <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
|
@wForget plz review it. Thanks. |
wForget
reviewed
Apr 11, 2024
| @@ -54,7 +54,8 @@ object MySQLErrPacket { | |||
| case kse: KyuubiSQLException if kse.getCause != null => | |||
| // prefer brief nested error message instead of whole stacktrace | |||
| apply(kse.getCause) | |||
| case e: Exception if e.getMessage contains "NoSuchDatabaseException" => | |||
| case e: Exception | |||
| if (e.getMessage != null) && (e.getMessage contains "NoSuchDatabaseException") => | |||
There was a problem hiding this comment.
Suggested change
| if (e.getMessage != null) && (e.getMessage contains "NoSuchDatabaseException") => | |
| if e.getMessage != null && e.getMessage.contains("NoSuchDatabaseException") => |
|
Please complete the checklist |
cxzl25
approved these changes
Apr 11, 2024
yikf
approved these changes
Apr 11, 2024
pan3793
changed the title
pan3793
pushed a commit
that referenced
this pull request
Apr 11, 2024
# 🔍 Description as title ## Issue References 🔗 This pull request fixes #6291 ## Describe Your Solution 🔧 Add a rule to check if it's null ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6292 from zhaohehuhu/dev-0411. Closes #6291 a58eed6 [hezhao2] refactor 40ad5e0 [hezhao2] Avoid NPE in MySQLErrPacket e02be17 [dupeng] [KYUUBI #6288] [KYUUBI #6283] Improve the message of distribution built without enabling web ui Lead-authored-by: hezhao2 <[email protected]> Co-authored-by: dupeng <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit f43cc59) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Apr 11, 2024
# 🔍 Description as title ## Issue References 🔗 This pull request fixes #6291 ## Describe Your Solution 🔧 Add a rule to check if it's null ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6292 from zhaohehuhu/dev-0411. Closes #6291 a58eed6 [hezhao2] refactor 40ad5e0 [hezhao2] Avoid NPE in MySQLErrPacket e02be17 [dupeng] [KYUUBI #6288] [KYUUBI #6283] Improve the message of distribution built without enabling web ui Lead-authored-by: hezhao2 <[email protected]> Co-authored-by: dupeng <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit f43cc59) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Apr 11, 2024
# 🔍 Description as title ## Issue References 🔗 This pull request fixes #6291 ## Describe Your Solution 🔧 Add a rule to check if it's null ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6292 from zhaohehuhu/dev-0411. Closes #6291 a58eed6 [hezhao2] refactor 40ad5e0 [hezhao2] Avoid NPE in MySQLErrPacket e02be17 [dupeng] [KYUUBI #6288] [KYUUBI #6283] Improve the message of distribution built without enabling web ui Lead-authored-by: hezhao2 <[email protected]> Co-authored-by: dupeng <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit f43cc59) Signed-off-by: Cheng Pan <[email protected]>
|
Merged to master(1.10.0)/1.9.1/1.8.2/1.7.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
as title
Issue References 🔗
This pull request fixes #6291
Describe Your Solution 🔧
Add a rule to check if it's null
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.